Release proximity wakelock on Element Call when call ends#6825
Merged
Conversation
The `CoroutineScope` that launched this logic was cancelled by that point, so the wakelock was never released.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6825 +/- ##
========================================
Coverage 81.26% 81.27%
========================================
Files 2648 2648
Lines 74170 74168 -2
Branches 9622 9622
========================================
Hits 60277 60277
+ Misses 10341 10339 -2
Partials 3552 3552 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
The
CoroutineScopethat launched this logic was cancelled by that point, so the wakelock was never released. Since the call already ended it should be OK to skip the mutex and ensure the wakelock is released in the main thread.Motivation and context
Replacement of #6752.
Fixes #6815.
Tests
Tested devices
Checklist